> > On 4/13/24 04:48, Avri Altman wrote: > > >> + nutrs = (hba->capabilities & MASK_TRANSFER_REQUESTS_SLOTS) + 1; > > > Isn't this already hba->nutrs? > > > > Enabling MCQ causes the value of NUTRS to change. > But not by the time ufshcd_mcq_decide_queue_depth is called. > ufshcd_mcq_decide_queue_depth is where hba->nutrs may change. > > > > > >> + WARN_ONCE(nutrs < 32, "nutrs: %d < 32\n", nutrs); > > > redundant > > > > Why is this considered redundant? > I see no point checking the hw. > Both In legacy & MCQ it is allowed to be < 32 - why the WARN? If any, the check proposed here - https://lore.kernel.org/lkml/DM6PR04MB6575720218D06C3EF9721BF2FC639@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/ Makes more sense to me. Thanks, Avri > > Thanks, > Avri > > > > Thanks, > > > > Bart.
