On Fri, Apr 12, 2024 at 10:41:29AM -0700, Bart Van Assche wrote: > Simplify the UFSHCI core and also the UFSHCI host drivers by removing > the .get_hba_mac() callback and by reading the NUTRS register field > instead. > This quite clearly states that the change is merely a cleanup. Can you confirm that (capabilities & 0xff) + 1 read back as 64 on both Mediatek and Qualcomm platforms? Such that this indeed is merely a cleanup... If not, please split the change in two; one that drops the callback in favor of always using MAX_SUPP_MAC, and a separate change that instead reads the value back. Please provide a clear problem description in your commit messages. Regards, Bjorn