Re: [PATCH] scsi: ufs: Remove .get_hba_mac()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 12, 2024 at 10:41:29AM -0700, Bart Van Assche wrote:
> Simplify the UFSHCI core and also the UFSHCI host drivers by removing
> the .get_hba_mac() callback and by reading the NUTRS register field
> instead.
> 

This quite clearly states that the change is merely a cleanup. Can you
confirm that (capabilities & 0xff) + 1 read back as 64 on both Mediatek
and Qualcomm platforms? Such that this indeed is merely a cleanup...

If not, please split the change in two; one that drops the callback in
favor of always using MAX_SUPP_MAC, and a separate change that instead
reads the value back.


Please provide a clear problem description in your commit messages.

Regards,
Bjorn




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux