RE: [PATCH] scsi: ufs: Remove .get_hba_mac()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On 4/13/24 04:48, Avri Altman wrote:
> >> +       nutrs = (hba->capabilities & MASK_TRANSFER_REQUESTS_SLOTS) + 1;
> > Isn't this already hba->nutrs?
> 
> Enabling MCQ causes the value of NUTRS to change.
But not by the time ufshcd_mcq_decide_queue_depth is called.
ufshcd_mcq_decide_queue_depth is where hba->nutrs may change.

> 
> >> +       WARN_ONCE(nutrs < 32, "nutrs: %d < 32\n", nutrs);
> > redundant
> 
> Why is this considered redundant?
I see no point checking the hw.
Both In legacy & MCQ it is allowed to be < 32 - why the WARN?

Thanks,
Avri
> 
> Thanks,
> 
> Bart.





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux