Replace Karen with Varun. On 11/18/22 6:17 AM, Denis Arefev wrote: > Return value of a function 'alloc_wr' is dereferenced at cxgb4i.c:624 > without checking for null, but it is usually checked for this function > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Signed-off-by: Denis Arefev <arefev@xxxxxxxxx> > --- > drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c > index 2c3491528d42..b93bd36dcb2d 100644 > --- a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c > +++ b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c > @@ -620,6 +620,8 @@ static inline int send_tx_flowc_wr(struct cxgbi_sock *csk) > #endif > flowclen16 = tx_flowc_wr_credits(&nparams, &flowclen); > skb = alloc_wr(flowclen, 0, GFP_ATOMIC); > + if (!skb) > + return -ENOMEM; If this returns a negative value push_tx_frames is going to mishandle it. I'm not sure how to best handle the failure there, but I cc'd the correct maintainer, Varun.
