On Fri, 18 Nov 2022, Bart Van Assche wrote: > On 11/18/22 13:34, Finn Thain wrote: > > On Fri, 18 Nov 2022, Bart Van Assche wrote: > > > >> There is more Linux kernel code that [...] than code that [...]. > > > > Thus mediocrity prevails. > > Mediocrity? I don't understand the above comment. I'm afraid it was poorly expressed. > Personally I prefer the style without !! and I don't think that it's a > mediocre style. > My comment goes to the rationale you gave not the decision you made. Regarding the decision, it's a choice between "explicit is better than implicit" and "brevity is better than redundancy". The patch opted for the former, you opted for the latter. I also have an opinion, but I'm not the maintainer so I'll keep it to myself. Regarding the rationale, a maintainer who merely follows the majority is not actually doing code review. This will lead to mediocrity.
