On 9/28/22 19:53, Mike Christie wrote:
+int __scsi_exec_req(struct scsi_exec_args *args)
Has it been considered to change the argument list into "const struct scsi_exec_args *args"?
-#define scsi_execute(sdev, cmd, data_direction, buffer, bufflen, sense, \ - sshdr, timeout, retries, flags, rq_flags, resid) \ +#define scsi_execute(_sdev, _cmd, _data_dir, _buffer, _bufflen, _sense, \ + _sshdr, _timeout, _retries, _flags, _rq_flags, \ + _resid) \
I don't think that the added underscores are necessary. Has it been considered not to change the argument names? Thanks, Bart.