Re: [PATCH v2 03/35] scsi: Add struct for args to execution functions

Bart Van Assche <bvanassche@xxxxxxx> · Thu, 29 Sep 2022 13:29:43 -0700

On 9/29/22 13:24, Mike Christie wrote:
You mean like:

#define scsi_exec_req(_args)                                            \
({                                                                      \
         BUILD_BUG_ON((_args).sense &&                                   \
                      (_args).sense_len != SCSI_SENSE_BUFFERSIZE);       \
         __scsi_exec_req(&(_args));                                      \
})

right? That didn't help. You still get the error:

error: macro "scsi_exec_req" passed 8 arguments, but takes just 1

Interesting. That may be a compiler bug but means that we need to keep the
parentheses ...

I would appreciate it if the parentheses could be inserted in the
scsi_exec_req() definition as shown above since this is the recommended kernel
coding style.

Thanks,

Bart.