On 9/29/22 7:12 PM, Bart Van Assche wrote: > On 9/28/22 19:53, Mike Christie wrote: >> +int __scsi_exec_req(struct scsi_exec_args *args) > > Has it been considered to change the argument list into "const struct > scsi_exec_args *args"? Yeah I meant to ask you about this. We do end up updating resid, sense buf, and sshdr, but because those are pointers I can make it "const struct scsi_exec_args *args" and it's fine since we are not updating fields like buf_len. I was thinking you wanted fields like cmd const though. So do you want 1. "const struct scsi_exec_args *args" plus 2. pointers on that struct that we don't modify like cmd and sdev also const. ? > >> -#define scsi_execute(sdev, cmd, data_direction, buffer, bufflen, sense, \ >> - sshdr, timeout, retries, flags, rq_flags, resid) \ >> +#define scsi_execute(_sdev, _cmd, _data_dir, _buffer, _bufflen, _sense, \ >> + _sshdr, _timeout, _retries, _flags, _rq_flags, \ >> + _resid) \ > > I don't think that the added underscores are necessary. Has it been > considered not to change the argument names? I can do that.
