On 9/22/22 11:59 AM, Bart Van Assche wrote: > On 9/22/22 03:06, Mike Christie wrote: >> + while ((failure = &scmd->failures[i++])) { > > Has this patch been verified with checkpatch? I don't think that the Linux kernel coding style allows assignments inside conditions. > Yes. With --strict that part was fine. --strict just didn't like me adding a new line further down the function, but I thought it looked weird without the new line.