Re: [PATCH RFC 02/22] scsi: Allow passthrough to override what errors to retry

To: Mike Christie <michael.christie@xxxxxxxxxx>, mwilck@xxxxxxxx, hch@xxxxxx, martin.petersen@xxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, james.bottomley@xxxxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH RFC 02/22] scsi: Allow passthrough to override what errors to retry
From: Bart Van Assche <bvanassche@xxxxxxx>
Date: Thu, 22 Sep 2022 09:59:44 -0700
In-reply-to: <20220922100704.753666-3-michael.christie@oracle.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0

On 9/22/22 03:06, Mike Christie wrote:

+	while ((failure = &scmd->failures[i++])) {

Has this patch been verified with checkpatch? I don't think that theLinux kernel coding style allows assignments inside conditions.


Thanks,

Bart.

Follow-Ups:
- Re: [PATCH RFC 02/22] scsi: Allow passthrough to override what errors to retry
  - From: michael . christie

References:
- [PATCH RFC 00/22] Allow scsi_execute users to control retries
  - From: Mike Christie
- [PATCH RFC 02/22] scsi: Allow passthrough to override what errors to retry
  - From: Mike Christie