On 9/22/22 12:03 PM, Bart Van Assche wrote: > On 9/22/22 03:06, Mike Christie wrote: >> + struct scsi_failure failures[] = { >> + { >> + .sense = UNIT_ATTENTION, >> + .asc = 0x28, >> + .ascq = 0, >> + .allowed = 3, >> + .result = SAM_STAT_CHECK_CONDITION, >> + }, >> + { >> + .sense = UNIT_ATTENTION, >> + .asc = 0x29, >> + .ascq = 0, >> + .allowed = 3, >> + .result = SAM_STAT_CHECK_CONDITION, >> + }, >> + {}, >> + }; > > Can the 'failures' array be declared 'static const'? No, the struct scsi_failures in there get updated when we track how many times we've hit the error.