Re: [PATCH 2/3] Farther clean-up of tmscsim driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 14 Jun 2007, Boaz Harrosh wrote:

> >From 4a7ac954dcc11531a09fa07d6a6365d98c67b216 Mon Sep 17 00:00:00 2001
> From: Boaz Harrosh <bharrosh@bh-buildlin2.(none)>
> Date: Thu, 14 Jun 2007 19:04:17 +0300
> Subject: [PATCH] Farther clean-up of tmscsim driver
> 
>  - this is a followup of commit 85289f2efa108d1586a86d0c426ffc9d641bbdc2
>    [SCSI] tmscsim: convert to use the data buffer accessors.
>    The saved sg_count was a leftover from the time the driver was doing
>    dma mapping by himself. But now that scsi-ml is called for the mapping
>    it is not the drivers responsibility.

Apart from being line-wrapped and missing a "Signed-off-by" tag, this 
patch looks ok to me. Please resend properly formatted and then you can 
add my

Signed-off-by: G. Liakhovetski <g.liakhovetski@xxxxxx>

Thanks
Guennadi

> ---
>  drivers/scsi/tmscsim.c |    3 ---
>  drivers/scsi/tmscsim.h |    1 -
>  2 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/scsi/tmscsim.c b/drivers/scsi/tmscsim.c
> index 73c5ca0..5758f20 100644
> --- a/drivers/scsi/tmscsim.c
> +++ b/drivers/scsi/tmscsim.c
> @@ -1680,7 +1680,6 @@ dc390_RequestSense(struct dc390_acb* pACB, struct dc390_dcb*
> pDCB, struct dc390_
>  			      pcmd->cmnd[0], pDCB->TargetID, pDCB->TargetLUN));
> 
>  	pSRB->SRBFlag |= AUTO_REQSENSE;
> -	pSRB->SavedSGCount = scsi_sg_count(pcmd);
>  	pSRB->SavedTotXLen = pSRB->TotalXferredLen;
>  	pSRB->AdaptStatus = 0;
>  	pSRB->TargetStatus = 0; /* CHECK_CONDITION<<1; */
> @@ -1728,7 +1727,6 @@ dc390_SRBdone( struct dc390_acb* pACB, struct dc390_dcb*
> pDCB, struct dc390_srb*
>  		       (u32) pcmd->result, (u32) pSRB->TotalXferredLen));
>  	    } else {
>  		SET_RES_DRV(pcmd->result, DRIVER_SENSE);
> -		scsi_sg_count(pcmd) = pSRB->SavedSGCount;
>  		//pSRB->ScsiCmdLen	 = (u8) (pSRB->Segment1[0] >> 8);
>  		DEBUG0 (printk ("DC390: RETRY pid %li (%02x), target %02i-%02i\n", pcmd->pid,
> pcmd->cmnd[0], pcmd->device->id, pcmd->device->lun));
>  		pSRB->TotalXferredLen = 0;
> @@ -1750,7 +1748,6 @@ dc390_SRBdone( struct dc390_acb* pACB, struct dc390_dcb*
> pDCB, struct dc390_srb*
>  	else if( status_byte(status) == QUEUE_FULL )
>  	{
>  	    scsi_track_queue_full(pcmd->device, pDCB->GoingSRBCnt - 1);
> -	    scsi_sg_count(pcmd) = pSRB->SavedSGCount;
>  	    DEBUG0 (printk ("DC390: RETRY pid %li (%02x), target %02i-%02i\n", pcmd->pid,
> pcmd->cmnd[0], pcmd->device->id, pcmd->device->lun));
>  	    pSRB->TotalXferredLen = 0;
>  	    SET_RES_DID(pcmd->result, DID_SOFT_ERROR);
> diff --git a/drivers/scsi/tmscsim.h b/drivers/scsi/tmscsim.h
> index c3d8c80..fbe7a3e 100644
> --- a/drivers/scsi/tmscsim.h
> +++ b/drivers/scsi/tmscsim.h
> @@ -57,7 +57,6 @@ u8		SGcount;
> 
>  u8		MsgCnt;
>  u8		EndMessage;
> -u8		SavedSGCount;			
> 
>  u8		MsgInBuf[6];
>  u8		MsgOutBuf[6];
> -- 
> 1.5.0.4.402.g8035
> 

---
Guennadi Liakhovetski
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux