>From 2b82909202cab8dc35184daef45b4b388f93112a Mon Sep 17 00:00:00 2001 From: Boaz Harrosh <bharrosh@bh-buildlin2.(none)> Date: Thu, 14 Jun 2007 19:14:40 +0300 Subject: [PATCH] Farther clean up of stex.c driver - now that scsi-ml accessors do not allow modifying of sg_count bufflen and sglist. The code in question is open coded to directly hack the scsi_cmnd structure. When implementation changes the driver will need to change with it. - Maintainer of this driver should please review again if we absolutely need this read-sense length fixing. What if less bytes are read and 0 are left at the end. Also no check is made if the buffer is large enough. --- drivers/scsi/stex.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c index adda296..d784b58 100644 --- a/drivers/scsi/stex.c +++ b/drivers/scsi/stex.c @@ -719,7 +719,7 @@ static void stex_ys_commands(struct st_hba *hba, if (ccb->cmd->cmnd[0] == MGT_CMD && resp->scsi_status != SAM_STAT_CHECK_CONDITION) { - scsi_bufflen(ccb->cmd) = + ccb->cmd->request_bufflen = le32_to_cpu(*(__le32 *)&resp->variable[0]); return; } -- 1.5.0.4.402.g8035 - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html