On Sun, 17 Jun 2007, Boaz Harrosh wrote: > I think the all thing is no longer relevant. It is leftovers from the time > scsi_error.c specifically scsi_send_eh_cmnd (used by scsi_request_sense) was > stepping all over the scsi_cmnd fields and things needed to be saved, if they > were needed for a retry. But now (since a later cleanup made by Christoph) > scsi_send_eh_cmnd() does not do that any more. Ok, what I really was trying to understand is the auto request sense path in tmscsim, and, I think, I have a better idea now how it is supposed to work. In fact, I don't know how really necessary this path is. I guess, requesting sense would anyway be handled by the ml, so, doing it in the lld is just a (micro-) optimization, right? So, though superfluous and making the driver less maintainable, we might keep it for now. > In any way pcmd->use_sg is > never touched anywhere in the code and any code called from this driver. > So why save it? > > Or am I missing some bigger picture Here? Looks like you're right. SavedSGCount seems indeed unneeded. I'll ack your patch. Thanks Guennadi --- Guennadi Liakhovetski - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
