Re: [PATCH v2 44/44] scsi: core: Remove struct scsi_pointer from struct scsi_cmnd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/8/22 09:54, John Garry wrote:
On 08/02/2022 17:25, Bart Van Assche wrote:
      /*
-     * The following fields can be written to by the host specific code.
-     * Everything else should be left alone.
+     * The fields below can be modified by the SCSI LLD but the fields
+     * above not.

"but the fields above not" - this sounds a bit odd, maybe this is better: "but the fields above may not be modified"

may not -> must not? See also https://en.wiktionary.org/wiki/must_not. Anyway, I can make that change.

And I don't think that we need to mention SCSI in that comment ..

I can leave the word "SCSI" out.

Thanks,

Bart.



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux