> On Feb 8, 2022, at 9:25 AM, Bart Van Assche <bvanassche@xxxxxxx> wrote:
>
> Remove struct scsi_pointer from struct scsi_cmnd since the previous patches
> removed all users of that member of struct scsi_cmnd. Additionally, reorder
> the members of struct scsi_cmnd such that the statement that the field
> below can be modified by the SCSI LLD is again correct.
>
> Cc: Ming Lei <ming.lei@xxxxxxxxxx>
> Cc: Hannes Reinecke <hare@xxxxxxxx>
> Cc: Christoph Hellwig <hch@xxxxxx>
> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@xxxxxxx>
> Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>
> ---
> include/scsi/scsi_cmnd.h | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/include/scsi/scsi_cmnd.h b/include/scsi/scsi_cmnd.h
> index 6794d7322cbd..4fd2c522e914 100644
> --- a/include/scsi/scsi_cmnd.h
> +++ b/include/scsi/scsi_cmnd.h
> @@ -123,11 +123,15 @@ struct scsi_cmnd {
> * command (auto-sense). Length must be
> * SCSI_SENSE_BUFFERSIZE bytes. */
>
> + int flags; /* Command flags */
> + unsigned long state; /* Command completion state */
> +
> + unsigned int extra_len; /* length of alignment and padding */
> +
> /*
> - * The following fields can be written to by the host specific code.
> - * Everything else should be left alone.
> + * The fields below can be modified by the SCSI LLD but the fields
> + * above not.
> */
> - struct scsi_pointer SCp; /* Scratchpad used by some host adapters */
>
> unsigned char *host_scribble; /* The host adapter is allowed to
> * call scsi_malloc and get some memory
> @@ -138,10 +142,6 @@ struct scsi_cmnd {
> * to be at an address < 16Mb). */
>
> int result; /* Status code from lower level driver */
> - int flags; /* Command flags */
> - unsigned long state; /* Command completion state */
> -
> - unsigned int extra_len; /* length of alignment and padding */
> };
>
> /* Variant of blk_mq_rq_from_pdu() that verifies the type of its argument. */
Reviewed-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>
--
Himanshu Madhani Oracle Linux Engineering
