Re: [PATCH v2 30/44] mvsas: Fix a set-but-not-used warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/8/22 09:50, John Garry wrote:
On 08/02/2022 17:25, Bart Van Assche wrote:
@@ -559,10 +558,14 @@ static int mvs_pci_init(struct pci_dev *pdev, const struct pci_device_id *ent)
          }
          nhost++;
      } while (nhost < chip->n_host);
-    mpi = (struct mvs_prv_info *)(SHOST_TO_SAS_HA(shost)->lldd_ha);
  #ifdef CONFIG_SCSI_MVSAS_TASKLET

I really doubt the value such config options

So do I, but removing that config option falls outside the scope of this patch series.
+    {
+    struct mvs_prv_info *mpi;
+
+    mpi = (struct mvs_prv_info *)(SHOST_TO_SAS_HA(shost)->lldd_ha);

nit: I don't think that we require the cast to struct mvs_prv_info *
Agreed, no explicit cast is required since lldd_ha has type 'void *'. I will remove the cast.

Thanks,

Bart.



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux