Re: [PATCH v3 06/46] scsi: zfcp: Switch to attribute groups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/11/21 6:26 AM, Benjamin Block wrote:
On Fri, Oct 08, 2021 at 01:23:13PM -0700, Bart Van Assche wrote:
-extern struct device_attribute *zfcp_sysfs_sdev_attrs[];
-extern struct device_attribute *zfcp_sysfs_shost_attrs[];
+extern const struct attribute_group *zfcp_sdev_attr_groups[];
+extern const struct attribute_group *zfcp_shost_attr_groups[];

I'd prefer it, if you leave the `zfcp_sysfs_` intact; while not
universally used in the whole driver, its a convention we've been trying
to follow regarding the symbols declared by the driver in the recent
time (`zfcp_sysfs.o` is the compilation unit).

Hi Benjamin,

I will restore these prefixes and post a fourth version of this patch series.

Thanks,

Bart.



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux