Hey Bart, just a small nitpick here. On Fri, Oct 08, 2021 at 01:23:13PM -0700, Bart Van Assche wrote: > struct device supports attribute groups directly but does not support > struct device_attribute directly. Hence switch to attribute groups. > > Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx> > --- > drivers/s390/scsi/zfcp_ext.h | 4 +-- > drivers/s390/scsi/zfcp_scsi.c | 4 +-- > drivers/s390/scsi/zfcp_sysfs.c | 52 +++++++++++++++++++++++----------- > 3 files changed, 39 insertions(+), 21 deletions(-) > > diff --git a/drivers/s390/scsi/zfcp_ext.h b/drivers/s390/scsi/zfcp_ext.h > index 6bc96d70254d..7b7b567186d6 100644 > --- a/drivers/s390/scsi/zfcp_ext.h > +++ b/drivers/s390/scsi/zfcp_ext.h > @@ -184,8 +184,8 @@ extern const struct attribute_group *zfcp_sysfs_adapter_attr_groups[]; > extern const struct attribute_group *zfcp_unit_attr_groups[]; > extern const struct attribute_group *zfcp_port_attr_groups[]; > extern struct mutex zfcp_sysfs_port_units_mutex; > -extern struct device_attribute *zfcp_sysfs_sdev_attrs[]; > -extern struct device_attribute *zfcp_sysfs_shost_attrs[]; > +extern const struct attribute_group *zfcp_sdev_attr_groups[]; > +extern const struct attribute_group *zfcp_shost_attr_groups[]; I'd prefer it, if you leave the `zfcp_sysfs_` intact; while not universally used in the whole driver, its a convention we've been trying to follow regarding the symbols declared by the driver in the recent time (`zfcp_sysfs.o` is the compilation unit). -- Best Regards, Benjamin Block / Linux on IBM Z Kernel Development / IBM Systems IBM Deutschland Research & Development GmbH / https://www.ibm.com/privacy Vorsitz. AufsR.: Gregor Pillen / Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen / Registergericht: AmtsG Stuttgart, HRB 243294
