On Fri, Oct 08, 2021 at 01:23:08PM -0700, Bart Van Assche wrote: > A quote from Documentation/driver-api/driver-model/device.rst: > "Word of warning: While the kernel allows device_create_file() and > device_remove_file() to be called on a device at any time, userspace has > strict expectations on when attributes get created. When a new device is > registered in the kernel, a uevent is generated to notify userspace (like > udev) that a new device is available. If attributes are added after the > device is registered, then userspace won't get notified and userspace will > not know about the new attributes." > > Hence register SCSI host sysfs attributes before the SCSI host shost_dev > uevent is emitted instead of after that event has been emitted. > > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx> > --- > drivers/scsi/hosts.c | 23 ++++++++++- > drivers/scsi/scsi_priv.h | 4 +- > drivers/scsi/scsi_sysfs.c | 81 +++++++++++++++++++------------------- > include/scsi/scsi_device.h | 7 ++++ > include/scsi/scsi_host.h | 12 ++++++ > 5 files changed, 84 insertions(+), 43 deletions(-) > Reviewed-by: Benjamin Block <bblock@xxxxxxxxxxxxx> -- Best Regards, Benjamin Block / Linux on IBM Z Kernel Development / IBM Systems IBM Deutschland Research & Development GmbH / https://www.ibm.com/privacy Vorsitz. AufsR.: Gregor Pillen / Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen / Registergericht: AmtsG Stuttgart, HRB 243294
