Hi Martin, This is not exposed to userland anymore. We have submitted an IOCTL support in driver to expose these information and later dropped it since similar functionality can be achieved through libsas sysfs entries. Controller exposes the phy error counter and status information pages through IOMB. We retained this patch in driver thinking that it might be useful if we want to query these information through driver sysfs or by some other means. We are okay to drop this. Please suggest. Regards, Viswas G > -----Original Message----- > From: Martin K. Petersen <martin.petersen@xxxxxxxxxx> > Sent: Thursday, September 3, 2020 6:48 AM > To: Viswas G - I30667 <Viswas.G@xxxxxxxxxxxxx> > Cc: martin.petersen@xxxxxxxxxx; Viswas.G@xxxxxxxxxxxxxxxxx; linux- > scsi@xxxxxxxxxxxxxxx; Vasanthalakshmi Tharmarajan - I30664 > <Vasanthalakshmi.Tharmarajan@xxxxxxxxxxxxx>; Deepak Ukey - I31172 > <Deepak.Ukey@xxxxxxxxxxxxx>; yuuzheng@xxxxxxxxxx; > auradkar@xxxxxxxxxx; vishakhavc@xxxxxxxxxx; bjashnani@xxxxxxxxxx; > radha@xxxxxxxxxx; akshatzen@xxxxxxxxxx > Subject: Re: [PATCH v8 1/2] pm80xx : Support for get phy profile > functionality. > > EXTERNAL EMAIL: Do not click links or open attachments unless you know > the content is safe > > Hi Viswas! > > >> Where are these parameters made visible? > >> > >> Also, why not make the phy_errcnt members __le32 instead of using > >> __force? > > > > This was added to avoid sparse compiler warnings reported. > > Yes, but those warnings are indicative that your struct definitions are > problematic. I suggest you have one struct with __le32 members which you > use when querying the values from the hardware. And then another struct > that's host-endian. Which goes back to my first question: Where are these > phy parameters actually used and/or exposed to userland? > > -- > Martin K. Petersen Oracle Linux Engineering
