Re: [PATCH v8 1/2] pm80xx : Support for get phy profile functionality.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Viswas!

>> Where are these parameters made visible?
>>
>> Also, why not make the phy_errcnt members __le32 instead of using
>> __force?
>
> This was added to avoid sparse compiler warnings reported.

Yes, but those warnings are indicative that your struct definitions are
problematic. I suggest you have one struct with __le32 members which you
use when querying the values from the hardware. And then another struct
that's host-endian. Which goes back to my first question: Where are
these phy parameters actually used and/or exposed to userland?

-- 
Martin K. Petersen	Oracle Linux Engineering



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux