> -----Original Message-----
> From: Martin K. Petersen <martin.petersen@xxxxxxxxxx>
> Sent: Wednesday, September 2, 2020 6:50 AM
> To: Viswas G <Viswas.G@xxxxxxxxxxxxxxxxx>
> Cc: linux-scsi@xxxxxxxxxxxxxxx; Vasanthalakshmi Tharmarajan - I30664
> <Vasanthalakshmi.Tharmarajan@xxxxxxxxxxxxx>; Viswas G - I30667
> <Viswas.G@xxxxxxxxxxxxx>; Deepak Ukey - I31172
> <Deepak.Ukey@xxxxxxxxxxxxx>; martin.petersen@xxxxxxxxxx;
> yuuzheng@xxxxxxxxxx; auradkar@xxxxxxxxxx; vishakhavc@xxxxxxxxxx;
> bjashnani@xxxxxxxxxx; radha@xxxxxxxxxx; akshatzen@xxxxxxxxxx
> Subject: Re: [PATCH v8 1/2] pm80xx : Support for get phy profile
> functionality.
>
> EXTERNAL EMAIL: Do not click links or open attachments unless you know
> the content is safe
>
> Viswas,
>
> > Added the support to get the phy profile which gives information about
> > the phy states, port and errors on phy.
>
> Where are these parameters made visible?
>
> Also, why not make the phy_errcnt members __le32 instead of using
> __force?
This was added to avoid sparse compiler warnings reported.
>
> + } else if (page_code == SAS_PHY_ERR_COUNTERS_PAGE) {
> + phy_err = (struct phy_errcnt *)ccb->resp_buf;
> + phy_err_cnt =
> + (struct phy_errcnt *)pPayload->ppc_specific_rsp;
> + phy_err->InvalidDword =
> + le32_to_cpu((__force __le32)phy_err_cnt->InvalidDword);
> + phy_err->runningDisparityError = le32_to_cpu
> + ((__force __le32)phy_err_cnt->runningDisparityError);
> + phy_err->LossOfSyncDW = le32_to_cpu
> + ((__force __le32)phy_err_cnt->LossOfSyncDW);
> + phy_err->phyResetProblem = le32_to_cpu
> + ((__force __le32)phy_err_cnt->phyResetProblem);
> + }
>
> --
> Martin K. Petersen Oracle Linux Engineering
