James Bottomley wrote: > This looks perfectly fine as a possible solution. Is there any reason > not to initialise qc->dma_dir unconditionally from the SCSI command? That should work too. I did what I did because it was more in line with what the current code assumed and initializing the field on qc alloc seemed like a good idea with or without unconditional qc->dma_dir = scmd->sc_data_direction because not all commands are translated from scsi command. > The only potential problem is DMA_BIDIRECTIONAL, which we don't use > (yet) ... but if it ever did come down libata will do the wrong thing > anyway. If that ever happens, libata probably should emulate it using multiple commands, I guess. Thanks. -- tejun - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
