Brian King wrote: > James Bottomley wrote: >> On Tue, 2007-01-16 at 17:45 -0500, Jeff Garzik wrote: >>> Tejun recently updated the CDB length areas of the code. I bet it's >>> either a bug somewhere in there, or the SCSI layer isn't passing us >>> proper command lengths in a case or two. >>> >>> Additional traces (starting with SCSI command, before it hits libata) >>> would be helpful. >> Actually, this looks like a potential bug in atapi_xlat(): it doesn't >> set qc->dma_dir. Shouldn't it be setting it from >> qc->scsicmd->sc_data_direction like ata_scsi_translate() does? > > I think we are OK here since atapi_xlate is only ever called by > ata_scsi_translate. I spoke too soon... ata_scsi_translate only sets up dma_dir if its a read or write, which means it never gets initialized if the direction is DMA_NONE. Brian -- Brian King eServer Storage I/O IBM Linux Technology Center - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
