On Sat, Dec 16 2006, FUJITA Tomonori wrote: > The following patches add SG v4 support to bsg. They are over Jens' > bsg branch. > > I just replaced bsg's SG v3 support with SG v4 and haven't added > anything new yet. So it can only handle SCSI commands. Good start! Just one comment before I look over this and merge it - I'd prefer keeping this out of sg.c. One of the problems we have right now are dual pieces of code for sg v3, and I think it would be silly to continue down this path. Lets keep sg.c as a legacy sg v3 interface (it'll be the only one except SG_IO in the block layer), and let bsg take sg v4 and forward. There's really zero gain in having it in two places. IOW, put the sg v4 structure in bsg.h. > I've uploaded simple programs to just read/write by using SG v4: > > http://www.kernel.org/pub/linux/kernel/people/tomo/sg4/ Great! I'll get this reviewed and merged as soon as I can, probably monday. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
