On 1/7/2020 11:32 PM, Hannes Reinecke wrote:
On 12/20/19 11:36 PM, James Smart wrote:
@@ -1995,7 +1995,7 @@ struct sli4_fc_xri_aborted_cqe {
#define SLI4_ELS_REQUEST64_DIR_READ 0x1
#define SLI4_ELS_REQUEST64_OTHER 0x0
-#define SLI4_ELS_REQUEST64_LOGO 0x1
+#define SLI4_ELS_REQUEST64_LOGO 0x1
#define SLI4_ELS_REQUEST64_FDISC 0x2
#define SLI4_ELS_REQUEST64_FLOGIN 0x3
#define SLI4_ELS_REQUEST64_PLOGI 0x4
Shouldn't this rather be merged with the previous patch?
yes - will do so
Make this two enums, one 'enum sli4_mbx_cmd' and one 'enum sli4_mbx_status'.
...
Single enum should rather be converted into a #define ..
...
Why is this an enum, and the above SLI4_INIT_LINK_F_XXX value are defines?
Please be consistent.
And this applies throughout the remainder of the patch.
Cheers,
Hannes
We will convert to multiple enums.
Thanks
-- james
