On 1/7/2020 11:24 PM, Hannes Reinecke wrote:
I am really not a big fan of anonymous enums, especially not if they are
scoped for specific structures.
Can you please avoid the use of anonymous enums, and name them according
to the structure where they are indended to be used?
Ideally the structure should reference named enums directly, but I do
agree that this it not always possible or desired.
But we should at least name them accordingly to give the developer a
hint where these values are expected to occur.
Eg in the above case
enum sli4_sge_flags {
or similar would make the intended usage clearer.
We will add names to the enums as suggested.
Thanks
-- james
