On 1/7/2020 11:11 PM, Hannes Reinecke wrote:
Please be consistent here wrt _SHIFT and _MASK statements. Either have them spelled out (as you do in this case), but then please change the first hunk to avoid an explicit shift. Or keep the style in the first hunk, and change the _MASK values here to use the _SHIFT values (ie SLI4_EQCQ_ID_HI_MASK = 0x1F << SLI4_EQCQ_ID_HI_SHIFT). I don't mind either way, but keep it consistent. Cheers, Hannes
We will do the change to spell out the _MASK directly. Thanks -- james
