Re: [PATCH 1/2] scsi: core: don't pre-allocate small SGL in case of NO_SG_CHAIN

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +#ifndef CONFIG_ARCH_NO_SG_CHAIN
>  #define  SCSI_INLINE_PROT_SG_CNT  1
> -
>  #define  SCSI_INLINE_SG_CNT  2
> +#else
> +#define  SCSI_INLINE_PROT_SG_CNT  0
> +#define  SCSI_INLINE_SG_CNT  0
> +#endif

Please avoid the double negative and just use an ifdef.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux