On Tue, Jun 04, 2019 at 04:23:08PM +0800, Ming Lei wrote: > The driver supporses that there isn't sg chain, and itereate the s/supporses/expects/ ? > + struct scatterlist *sgt; Maybe just call this s, which is a common name for scatterlist iterators? sgt is used for a sg table in many places in scsi. Otherwise looks fine: Reviewed-by: Christoph Hellwig <hch@xxxxxx>