> On Sep 17, 2018, at 1:03 PM, Bart Van Assche <bvanassche@xxxxxxx> wrote: > > External Email > > On 9/17/18 12:07 PM, Madhani, Himanshu wrote: >> >>> On Sep 15, 2018, at 9:53 PM, Bart Van Assche <bvanassche@xxxxxxx> wrote: >>> >>> External Email >>> >>> On 09/14/18 14:28, Himanshu Madhani wrote: >>>> diff --git a/drivers/scsi/qla2xxx/Kconfig b/drivers/scsi/qla2xxx/Kconfig >>>> index 036cc3f217b1..f1539d8b68ef 100644 >>>> --- a/drivers/scsi/qla2xxx/Kconfig >>>> +++ b/drivers/scsi/qla2xxx/Kconfig >>>> @@ -3,6 +3,7 @@ config SCSI_QLA_FC >>>> depends on PCI && SCSI >>>> depends on SCSI_FC_ATTRS >>>> depends on NVME_FC || !NVME_FC >>>> + depends on NVME_TARGET_FC || !NVME_TARGET_FC >>> >>> Why has this line been added? >>> >> >> We’ve added this to indicate NVMe Target support with the driver. >> anything that I am missing? > > Hello Himanshu, > > Does the qla2xxx driver build with CONFIG_NVME_TARGET_FC=y, > CONFIG_NVME_TARGET_FC=m and CONFIG_NVME_TARGET_FC=n? If so, why do you > think that the line "depends on NVME_TARGET_FC || !NVME_TARGET_FC" is > necessary? > Okay. we’ll revisit this and post update. Thanks. > Thanks, > > Bart. Thanks, - Himanshu
