> On Sep 11, 2018, at 2:22 PM, Laura Abbott <labbott@xxxxxxxxxx> wrote: > > There's currently a warning about string overflow with strncat: > > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function 'ibmvscsis_probe': > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3479:2: error: 'strncat' specified > bound 64 equals destination size [-Werror=stringop-overflow=] > strncat(vscsi->eye, vdev->name, MAX_EYE); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Switch to a single snprintf instead of a strcpy + strcat to handle this > cleanly. > > Signed-off-by: Laura Abbott <labbott@xxxxxxxxxx> > --- > v3: Make sure there is an extra space in the partition name > --- > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > Reviewed-by: Bryant G. Ly bly@xxxxxxxxxxxxxxxxxxxxx I sent a PR to update my email from bryantly@xxxxxxxxxxxxxxxxxx a week ago. -Bryant
