Re: [PATCH 2/6] qla2xxx_nvmet: Added Makefile and Kconfig changes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On Sep 15, 2018, at 9:53 PM, Bart Van Assche <bvanassche@xxxxxxx> wrote:
> 
> External Email
> 
> On 09/14/18 14:28, Himanshu Madhani wrote:
>> diff --git a/drivers/scsi/qla2xxx/Kconfig b/drivers/scsi/qla2xxx/Kconfig
>> index 036cc3f217b1..f1539d8b68ef 100644
>> --- a/drivers/scsi/qla2xxx/Kconfig
>> +++ b/drivers/scsi/qla2xxx/Kconfig
>> @@ -3,6 +3,7 @@ config SCSI_QLA_FC
>>      depends on PCI && SCSI
>>      depends on SCSI_FC_ATTRS
>>      depends on NVME_FC || !NVME_FC
>> +     depends on NVME_TARGET_FC || !NVME_TARGET_FC
> 
> Why has this line been added?
> 

We’ve added this to indicate NVMe Target support with the driver. 
anything that I am missing? 

> Please also consider to fold this patch into the first patch. I don't
> think it makes sense that patches 1/6 and 2/6 are separate.
> 

Sure

> Bart.

Thanks,
- Himanshu





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux