Thanks, Avri +AD4- -----Original Message----- +AD4- From: Bart Van Assche +AD4- Sent: Wednesday, August 01, 2018 6:39 PM +AD4- To: hch+AEA-lst.de+ADs- Avri Altman +ADs- linux-scsi+AEA-vger.kernel.org+ADs- +AD4- jthumshirn+AEA-suse.de+ADs- hare+AEA-suse.com+ADs- martin.petersen+AEA-oracle.com+ADs- +AD4- jejb+AEA-linux.vnet.ibm.com +AD4- Cc: Vinayak Holikatti +ADs- Avi Shchislowski +ADs- Alex Lemberg +ADs- Stanislav Nijnikov +ADs- +AD4- subhashj+AEA-codeaurora.org +AD4- Subject: Re: +AFs-PATCH 6/6+AF0- scsi: ufs-bsg: Add support for uic commands in +AD4- ufs+AF8-bsg+AF8-request() +AD4- +AD4- On Wed, 2018-08-01 at 11:04 +-0300, Avri Altman wrote: +AD4- +AD4- +- struct uic+AF8-command uc +AD0- +AHs-0+AH0AOw- +AD4- +AD4- Please use +ACIAew- +AH0AIg- or +ACIAewB9ACI- for structure initialization as is done elsewhere in +AD4- the kernel instead of +ACIAew-0+AH0AIg-. Done. +AD4- +AD4- +AD4- +-+ACM-define UIC+AF8-CMD+AF8-SIZE (sizeof(u32) +ACo- 4) +AD4- +AD4- Please add a comment above this definition that explains whether this +AD4- constant +AD4- comes from the spec or whether it has another origin. Done. +AD4- +AD4- Thanks, +AD4- +AD4- Bart.
