On Wed, 2018-08-01 at 11:04 +-0300, Avri Altman wrote: +AD4- +- struct uic+AF8-command uc +AD0- +AHs-0+AH0AOw- Please use +ACIAew- +AH0AIg- or +ACIAewB9ACI- for structure initialization as is done elsewhere in the kernel instead of +ACIAew-0+AH0AIg-. +AD4- +-+ACM-define UIC+AF8-CMD+AF8-SIZE (sizeof(u32) +ACo- 4) Please add a comment above this definition that explains whether this constant comes from the spec or whether it has another origin. Thanks, Bart.