[PATCH V7 0/2] Add UFS provisioning support in driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This patch adds Configfs support to provision UFS device at
runtime. This feature can be primarily useful in factory or
assembly line as some devices may be required to be configured
multiple times during initial system development phase.
Configuration Descriptors can be written multiple times until
bConfigDescrLock attribute is zero.

Configuration descriptor buffer consists of Device and Unit
descriptor configurable parameters which are parsed from vendor
specific provisioning file and then passed via configfs node at
runtime to provision ufs device.

Changes since V6:
	1)scsi: ufs: set the device reference clock setting
	Re-introduced this patch to provisioning patch set(as per comments
	from Evan). Used of_clk_get_by_name() and clk_get_rate() to set
	ref_clk frequency instead of passing freq via DT.
	 
	2)scsi: ufs: Add configfs support for UFS provisioning
	Updated error handling in case if kstrtoint fails while parsing
	input configuration buffer.

Changes since V5:
	1)scsi: ufs: set the device reference clock setting
	Removed this patch from provisioning patch set(as its not required
	to be set as dependent changes).
	This will be uploaded as a separate patch later.
	 
	2)scsi: ufs: Add configfs support for UFS provisioning
	Removed few extra debug prints. Updated permission of ufs_provision
	attribute from 0666 to 0644. Pass UFS device name as part of
	ufshcd_configfs_init() to support multiple UFS controller for
	embedded and removable UFS card.

Changes since V4:
	1)scsi: ufs: set the device reference clock setting
	Used "assigned-clock-rates" DT property to pass required ref clk
	frequency.

	2)scsi: ufs: Add configfs support for ufs provisioning
	Combined previous patch(2) and patch(3) into single patch which
	adds configfs provisioning support in driver.
	Removed extra sw provisioning related fields (like lun_to_grow,
	commit) and its related code.
	Updated Documentation to match configuration descriptor buffer
	parameters to be passed as per specs. Removed global ufs_hba ptr
	added in ufs-configfs file and instead passed *hba in ufs configfs
	init()/store()/show() api's. This is to support embedded as well as
	removable ufs card provisioning via configfs.

Changes since V3:
	1)scsi: ufs: set the device reference clock setting
	  Updated logic to retain default ref_clk frequency setting
	  programmed in device in case if invalid value is passed via
	  devicetree setting.
	  Replaced of_property_read_u32() with device_property_read_u32().
	  Removed invalid checks.

	2)scsi: ufs: Add ufs provisioning support
	  Added pm_runtime_get/put_sync and scsi_block/unblock_request
	  in runtime provisioning for stable operation.
	     
  	3)scsi: ufs: Add configfs support for ufs provisioning
	  Updated Documentation with missing buffer entries required for
	  runtime provisioning. Used config option to support conditional
	  compilation for configfs api's.

Changes since V2:
	Added configfs support for ufs provisioning and removed sysfs
	support.

Changes since V1:
	Added device tree entry to parse reference clock frequency
	instead of hardcoding 19.2 MHz, as it can vary for different
	vendors. Also removed setting ref_clk again during runtime
	provisioning as it will be already set during probe.
	Used get_unaligned_be*/put_unaligned_be* where applicable.

Changes since RFC:
	Added check to avoid ufs runtime provisioning if
	Configuration decriptor lock attribute is set to one.
	Instead of parsing ref_clk frequency via device tree, used
	correct enum ref_clk_freq value(19.2 Mhz for proviosioning).
	Added config_descriptor sysfs entry to provision ufs and also
	updated documentation for its correct usage.
	Added more protection against bad data handling in sysfs code.

Sayali Lokhande (1):
  scsi: ufs: Add configfs support for UFS provisioning

Subhash Jadavani (1):
  scsi: ufs: set the device reference clock setting

 Documentation/ABI/testing/configfs-driver-ufs |  18 +++
 drivers/scsi/ufs/Kconfig                      |  10 ++
 drivers/scsi/ufs/Makefile                     |   1 +
 drivers/scsi/ufs/ufs-configfs.c               | 162 ++++++++++++++++++++++++++
 drivers/scsi/ufs/ufs.h                        |   8 ++
 drivers/scsi/ufs/ufshcd-pltfrm.c              |   2 +
 drivers/scsi/ufs/ufshcd.c                     |  91 ++++++++++++++-
 drivers/scsi/ufs/ufshcd.h                     |  12 ++
 8 files changed, 303 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/ABI/testing/configfs-driver-ufs
 create mode 100644 drivers/scsi/ufs/ufs-configfs.c

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux