Hi Martin,
Any comment for this patch ?
On Wed, Mar 7, 2018 at 2:25 AM, Souptick Joarder <jrdr.linux@xxxxxxxxx> wrote:
> Any comment for this patch.
>
> On Thu, Feb 15, 2018 at 10:09 PM, Souptick Joarder <jrdr.linux@xxxxxxxxx> wrote:
>> Use dma_pool_zalloc() instead of dma_pool_alloc + memset
>>
>> Signed-off-by: Souptick Joarder <jrdr.linux@xxxxxxxxx>
>> ---
>> drivers/scsi/aic94xx/aic94xx_hwi.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/scsi/aic94xx/aic94xx_hwi.c b/drivers/scsi/aic94xx/aic94xx_hwi.c
>> index 2dbc833..1b13133 100644
>> --- a/drivers/scsi/aic94xx/aic94xx_hwi.c
>> +++ b/drivers/scsi/aic94xx/aic94xx_hwi.c
>> @@ -1055,14 +1055,13 @@ static struct asd_ascb *asd_ascb_alloc(struct asd_ha_struct *asd_ha,
>>
>> if (ascb) {
>> ascb->dma_scb.size = sizeof(struct scb);
>> - ascb->dma_scb.vaddr = dma_pool_alloc(asd_ha->scb_pool,
>> + ascb->dma_scb.vaddr = dma_pool_zalloc(asd_ha->scb_pool,
>> gfp_flags,
>> &ascb->dma_scb.dma_handle);
>> if (!ascb->dma_scb.vaddr) {
>> kmem_cache_free(asd_ascb_cache, ascb);
>> return NULL;
>> }
>> - memset(ascb->dma_scb.vaddr, 0, sizeof(struct scb));
>> asd_init_ascb(asd_ha, ascb);
>>
>> spin_lock_irqsave(&seq->tc_index_lock, flags);
>> --
>> 1.9.1
>>
-Souptick
