Hi Martin,
Any comment for this patch ?
On Tue, Mar 6, 2018 at 1:31 PM, Souptick Joarder <jrdr.linux@xxxxxxxxx> wrote:
> Any comment for this patch.
>
> On Thu, Feb 15, 2018 at 9:28 PM, Souptick Joarder <jrdr.linux@xxxxxxxxx> wrote:
>> Use dma_pool_zalloc() instead of dma_pool_alloc + memset
>>
>> Signed-off-by: Souptick Joarder <jrdr.linux@xxxxxxxxx>
>> ---
>> drivers/scsi/mvsas/mv_sas.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/scsi/mvsas/mv_sas.c b/drivers/scsi/mvsas/mv_sas.c
>> index cff43bd..d00d37d 100644
>> --- a/drivers/scsi/mvsas/mv_sas.c
>> +++ b/drivers/scsi/mvsas/mv_sas.c
>> @@ -790,12 +790,11 @@ static int mvs_task_prep(struct sas_task *task, struct mvs_info *mvi, int is_tmf
>> slot->n_elem = n_elem;
>> slot->slot_tag = tag;
>>
>> - slot->buf = dma_pool_alloc(mvi->dma_pool, GFP_ATOMIC, &slot->buf_dma);
>> + slot->buf = dma_pool_zalloc(mvi->dma_pool, GFP_ATOMIC, &slot->buf_dma);
>> if (!slot->buf) {
>> rc = -ENOMEM;
>> goto err_out_tag;
>> }
>> - memset(slot->buf, 0, MVS_SLOT_BUF_SZ);
>>
>> tei.task = task;
>> tei.hdr = &mvi->slot[tag];
>> --
>> 1.9.1
>>
-Souptick
