On 2/19/2018 12:14 AM, Johannes Thumshirn wrote:
On Fri, Feb 16, 2018 at 08:53:44AM -0800, James Smart wrote:
Any reason you can't use writeq() on 32 Bit as well? There's a compat version
in linux/io-64-nonatomic-hi-lo.h.
We actually ran into issues on the existence of writeq() on a 32bit
platform. Thus this code block.
Oh can you elaborate more on the issue? I bet if we merge it that way, someone
comes around with a patch chaning it to writeq() on 32Bit as well.
Wouldn't it be better to improve the 32Bit writeq() code?
Well, now that I'm asking for specific details internally, I'm finding
that no one can find the failing machine any more.
I'm going to keep looking (and testing) for another day or two, and if
nothing pops up, will repost removing the 64bit define.
Generally speaking (same for the WC issue), ifdefs (especially architecture
specific ones) in driver code should be avoided.
Yes - I know. On the WC issue though, given how tightly bound the
behavior is with the platform as well as whether it provides a real
benefit vs a simple "it works", I don't believe this is one that I want
to be "generic" on.
-- james
