On Fri, Feb 16, 2018 at 08:53:44AM -0800, James Smart wrote: > > Any reason you can't use writeq() on 32 Bit as well? There's a compat version > > in linux/io-64-nonatomic-hi-lo.h. > > We actually ran into issues on the existence of writeq() on a 32bit > platform. Thus this code block. Oh can you elaborate more on the issue? I bet if we merge it that way, someone comes around with a patch chaning it to writeq() on 32Bit as well. Wouldn't it be better to improve the 32Bit writeq() code? Generally speaking (same for the WC issue), ifdefs (especially architecture specific ones) in driver code should be avoided. Thanks, Johannes -- Johannes Thumshirn Storage jthumshirn@xxxxxxx +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
