On 28/08/06, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
On Sat, Aug 26, 2006 at 05:24:42AM +0200, Richard Knutsson wrote: > Hello > > Just would like to ask if you want patches for: Total NACK to any of this boolean ididocy. I very much hope you didn't get the impression you actually have a chance to get this merged. > > * (Most importent, may introduce bugs if left alone) > Fixing boolean checking, ex: > if (bool == FALSE) > to > if (!bool) this one of course makes sense, but please do it without introducing any boolean type. Getting rid of all the TRUE/FALSE defines and converting all scsi drivers to classic C integer as boolean semantics would be very welcome janitorial work.
If you'll take such patches I'd be willing to clean up a few drivers.. Any specific ones you'd like me to start with? -- Jesper Juhl <jesper.juhl@xxxxxxxxx> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
