Hello, Christoph. On Thu, Mar 23, 2017 at 03:43:30PM +0100, Christoph Hellwig wrote: > > That's up to you ... from the point of view of code documenting itself, > > forming the ATA_16 TRIM in sd and not doing any satl transformation is > > easier for others to follow, but if it's going to cause more code, I'm > > only marginal on the advantages of easier to follow code. > > I tried this earlier before giving up on it because it looked to ugly. > But I can complete that version of it and post it for people to compare. I kinda like the idea of sticking with satl as that's how libata has been doing most things even if the implementation is uglier. It'd be great to find out whether the ugliness would be acceptable or too much. Thanks. -- tejun
