Hello, On Mon, Mar 20, 2017 at 04:43:12PM -0400, Christoph Hellwig wrote: > This series implements rangeѕ discard for ATA SSDs. Compared to the > initial NVMe support there are two things that complicate the ATA > support: > > - ATA only suports 16-bit long ranges > - the whole mess of generating a SCSI command first and then > translating it to an ATA one. > > This series adds support for limited range size to the block layer, > and stops translating discard commands - instead we add a new > Vendor Specific SCSI command that contains the TRIM payload when > the device asks for it. I do like the fact that this is a lot simpler than the previous implementation but am not quite sure we want to deviate significantly from what we do for other commands (command translation). Is it because fixing the existing implementation would involve invaisve changes including memory allocations? Thanks. -- tejun
