Matthew Wilcox wrote:
On Wed, Jun 21, 2006 at 08:04:36PM +0200, Stefan Richter wrote:
What is wrong with the current two-line format?
Several things. The way that it's printed means that simultaneous scans
lead to the output getting garbled.
That's true, but it could be implemented as an atomic operation with
multiple printks nonetheless. However you are right, layout should not
be a reason to add locks. Make it one printk, but please keep it
readable. The inquiry printout is one of the few that people actually
care for.
You're exaggerating.
On purpose. :-)
BTW, here's what a line would look like from sbp2 ...
scsi 9:0:0:0: CD-ROM MATSHITA UJDA730 DVD/CDRW 1.00 Level: 0
Here is another SBP-2 device:
Vendor: ST340083 Model: 2A Rev: 3.01
Type: Direct-Access-RBC ANSI SCSI revision: 04
This may be misleading if "Vendor:" and "Model:" prefixes are stripped.
btw, I've always found that "CD-ROM" a little confusing; considering
that SPC4 says "CD/DVD device", any objections to changing that string
to say "CD/DVD" instead of "CD-ROM"?
Seems reasonable.
--
Stefan Richter
-=====-=-==- -==- =-==-
http://arcgraph.de/sr/
-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
