Re: [PATCH] Print SCSI Inquiry data more compactly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Matthew Wilcox wrote:
On Wed, Jun 21, 2006 at 01:18:43PM -0400, James Smart wrote:
scsi <2:0:1:0> x00:HP 18.2G:ATLAS10K3_18_SCA:HP05:02:
Eddie Williams wrote:
scsi 2:0:1:0:DASD:HP 18.2G:ATLAS10K3_18_SCA:HP05:02:
scsi 2:0:1:0: Direct-Access     HP 18.2G ATLAS10K3_18_SCA HP05 ANSI ver: 01 CCS
scsi 2:0:1:0: Direct-Access     xAB HP 18.2G ATLAS10K3_18_SCA HP05 Level: 03
scsi 2:0:1:0: Direct-Access     7 HP 18.2G ATLAS10K3_18_SCA HP05 Level: 03

All of these hurt eyes. What is wrong with the current two-line format?

One line too many? What about silencing protocol drivers first? sd puts out a lot of lines right after those inquiry data. What's more, sd is forced by some upper layer to go through the initialization twice, therefore sd sees fit to print its stuff out twice. This is where I see potential to reduce log noise.

Also keep in mind, the inquiry data in the syslog has been a source for users to feed the parameter scsi_mod.dev_flags. I.e. keep the vendor and model strings distinguishable.

And a beautiful layout of syslog messages is good for the mental peace of users.

Highly cryptic log messages on the other hand are about as valuable as _no_ log messages at all. The lines I quoted above are not far from white noise.

Again, what exactly is the gain from one log line less? The size of syslog files is taken care of by logrotate + gzip.

End of rant. :-)
--
Stefan Richter
-=====-=-==- -==- =-=-=
http://arcgraph.de/sr/
-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux