On Wed, Jun 21, 2006 at 01:18:43PM -0400, James Smart wrote: > I agree with Eddie's points, with another small recommendation: > > scsi <2:0:1:0> x00:HP 18.2G:ATLAS10K3_18_SCA:HP05:02: If you want to get brackets around the 2:0:1:0, you need to talk to jejb about getting sdev_printk changed. > where x00 is byte 1 of the inquiry data - device type and qualifier. > Clarifies the H:C:T:L as well. > > Eddie Williams wrote: > >Do you need the labels? How about > >scsi 2:0:1:0:DASD:HP 18.2G:ATLAS10K3_18_SCA:HP05:02: > > > >This keeps it short. For those that are probably looking at this data > >the labels are not needed anyway. It is easy to parse if someone wants. > >I used "DASD" just because that is what was referenced before. I think > >I would prefer the number or "direct access" but either way I would not > >lose any sleep. I used scsi_device_type to get the string, so "Direct Access" it is. Worst case, we get: scsi 2:0:1:0: Direct-Access HP 18.2G ATLAS10K3_18_SCA HP05 ANSI ver: 01 CCS so we're out of room unless we do one or both of: - ditch the "ANSI ver:" - print the scsi_level instead of "01 CCS" Using colons instead of spaces to improve parsing is misleading at best; there's nothing to stop vendors putting colons in their descriptions. And as I said earlier, there's no need to parse this data anyway. So we could do: scsi 2:0:1:0: Direct-Access xAB HP 18.2G ATLAS10K3_18_SCA HP05 Level: 03 if we really want to see the PQ. We could even just print the PQ: scsi 2:0:1:0: Direct-Access 7 HP 18.2G ATLAS10K3_18_SCA HP05 Level: 03 clocking in at a svelte 74 columns. - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
