On Thu, Apr 27, 2006 at 11:13:22AM +0200, Guido Guenther wrote: > we have a rather old EMC Symmetrix which always has a peripheral > qualifier of 001b on LUN0. This has the problem that the > scsi_probe_and_add_lun code bails out to out_free_result: before we > apply the device flags (that we got from scsi_probe_lun just before this > check) to bflagsp. The result is that (without these flags) we stop [..snip..] The previously attached patch has the issue that we add a device though not actually present just to safe the bflags. This version should do better: --- orig/linux-2.6.16.7/drivers/scsi/scsi_scan.c 2006-03-20 06:53:29.000000000 +0100 +++ linux-2.6.16.7/drivers/scsi/scsi_scan.c 2006-04-28 20:38:01.000000000 +0200 @@ -868,6 +868,12 @@ static int scsi_probe_and_add_lun(struct "scsi scan: peripheral qualifier of 3," " no device added\n")); res = SCSI_SCAN_TARGET_PRESENT; + + /* don't discard the already fetched bflags for lun 0 so + * __scsi_scan_target knows about them */ + if (bflagsp && lun == 0) + *bflagsp = bflags; + goto out_free_result; } Signed-Off-By: Guido Guenther <agx@xxxxxxxxxxx> Cheers, -- Guido - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
