On Fri, Apr 28, 2006 at 08:45:55PM +0200, Guido Guenther wrote: > On Thu, Apr 27, 2006 at 11:13:22AM +0200, Guido Guenther wrote: > > we have a rather old EMC Symmetrix which always has a peripheral > > qualifier of 001b on LUN0. This has the problem that the > > scsi_probe_and_add_lun code bails out to out_free_result: before we > > apply the device flags (that we got from scsi_probe_lun just before this > > check) to bflagsp. The result is that (without these flags) we stop > [..snip..] > The previously attached patch has the issue that we add a device though > not actually present just to safe the bflags. This version should do > better: > > --- orig/linux-2.6.16.7/drivers/scsi/scsi_scan.c 2006-03-20 06:53:29.000000000 +0100 > +++ linux-2.6.16.7/drivers/scsi/scsi_scan.c 2006-04-28 20:38:01.000000000 +0200 > @@ -868,6 +868,12 @@ static int scsi_probe_and_add_lun(struct > "scsi scan: peripheral qualifier of 3," > " no device added\n")); > res = SCSI_SCAN_TARGET_PRESENT; > + > + /* don't discard the already fetched bflags for lun 0 so > + * __scsi_scan_target knows about them */ > + if (bflagsp && lun == 0) > + *bflagsp = bflags; > + > goto out_free_result; > } A similar patch is already in scsi-misc and mm trees, you should test one of those. Here is the patch from Kurt that was accepted into scsi-misc: http://www.kernel.org/git/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=blobdiff;h=820c4ad7b5817e24550d50dd35ca740cd86de4fe;hp=f14945996ede5ec514bc0e390b506ffcfaa4d461;hb=4186ab1973758190916703eb8889ebe8002c5c8f;f=drivers/scsi/scsi_scan.c -- Patrick Mansfield - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
