On Fri, 2006-04-28 at 13:19 -0500, Brian King wrote: > That is what is done today, which works fine if you only have one > device per host, but when you have multiple devices per host, there is > no *good* value to put in the host max_cmd_len, hence the patch. This > could also be completely contained in libata as my previous post suggests, > if Jeff is OK with that. The value should be the minimum of the currently supported lengths. I presume we have 10, 12 and 16 for SATA? In which case the only problem is not doing 16 and then only if you want to go beyond 2TB ... Perhaps you could tell me what the actual failure case is? my recollection is that sd does either 6, 10 or 16, but that it only ever tries 16 if it has to access a sector beyond 2TB, so as a matter of practice, you should be safe even for a 10 only device on a host that supports 16. James - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html